Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 10, 2025

This PR re-quarantines the flaky test Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerRoutingTest.NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation and adds a reference to the tracking issue #61080.

Problem

The NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation test in the server execution context has been identified as flaky and needs to be quarantined to prevent it from causing CI build failures while the underlying issue is being investigated.

Solution

The test is quarantined by adding the [QuarantinedTest] attribute directly to the NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation method in RoutingTest.cs with a reference to the tracking issue #61080.

Key Benefits

  • Simple and direct: The quarantine is applied directly to the base test method, making it straightforward and easy to understand.
  • Proper tracking: The GitHub issue reference provides context for why the test is quarantined.
  • Clean implementation: No inheritance or overriding needed, keeping the code simple.

Changes Made

  • RoutingTest.cs: Added [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/61080")] attribute directly to the test method

The quarantined test will be excluded from regular CI builds but will continue to run on the daily quarantined test schedule, allowing monitoring of the fix progress.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Sep 10, 2025
…rlappingNavigationsCancelExistingNavigations_HistoryNavigation

Co-authored-by: oroztocil <[email protected]>
@Copilot Copilot AI changed the title [WIP] Re-quarantine Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerRoutingTest.NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation and add reference to @dotnet/aspnetcore/issues/61080 as the tracking issue Re-quarantine ServerRoutingTest.NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation Sep 10, 2025
Copilot finished work on behalf of oroztocil September 10, 2025 13:57
@Copilot Copilot AI requested a review from oroztocil September 10, 2025 13:57
@oroztocil oroztocil added area-blazor Includes: Blazor, Razor Components and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically Attention: Shared Code Modified labels Sep 10, 2025
@Copilot Copilot AI requested a review from oroztocil September 10, 2025 14:46
Copilot finished work on behalf of oroztocil September 10, 2025 14:46
@oroztocil oroztocil marked this pull request as ready for review September 10, 2025 15:37
@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 15:37
@oroztocil oroztocil requested a review from a team as a code owner September 10, 2025 15:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR quarantines a flaky test NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation by adding the [QuarantinedTest] attribute with a reference to tracking issue #61080. This prevents the test from causing CI build failures while the underlying issue is being investigated.

  • Adds quarantine attribute to prevent flaky test from breaking CI builds
  • Includes proper tracking issue reference for investigation context

@oroztocil oroztocil enabled auto-merge (squash) September 10, 2025 15:53
@oroztocil oroztocil merged commit 6f91a7d into main Sep 10, 2025
30 checks passed
@oroztocil oroztocil deleted the copilot/fix-cf7cc9ca-edd7-46b4-aad1-c4b62099b236 branch September 10, 2025 16:43
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Sep 10, 2025
@wtgodbe
Copy link
Member

wtgodbe commented Oct 7, 2025

/backport to release/9.0

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/18325772678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants